Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add useEscapeFormula option to ImportExportController #1256

Closed
wants to merge 2 commits into from
Closed

Add useEscapeFormula option to ImportExportController #1256

wants to merge 2 commits into from

Conversation

mjauvin
Copy link
Member

@mjauvin mjauvin commented Nov 26, 2024

This option allow to skip adding the CsvEscapeFormula to the CsvWriter formatters.
The default is true, preserving existing behavior.

One can change this option in the config_import_export as below:

export:
  fileName: export.csv
defaultFormatOptions:
  useEscapeFormula: false

@mjauvin mjauvin added enhancement PRs that implement a new feature or substantial change needs review Issues/PRs that require a review from a maintainer labels Nov 26, 2024
@mjauvin mjauvin added this to the 1.2.7 milestone Nov 26, 2024
@mjauvin mjauvin requested a review from bennothommo November 26, 2024 04:12
@mjauvin mjauvin self-assigned this Nov 26, 2024
@LukeTowers
Copy link
Member

@mjauvin see GHSA-4rhm-m2fp-hx7q for the background of why this is there in the first place.

@mjauvin
Copy link
Member Author

mjauvin commented Nov 26, 2024

@mjauvin see GHSA-4rhm-m2fp-hx7q for the background of why this is there in the first place.

Seems a bit farfetched, but ok...

@mjauvin
Copy link
Member Author

mjauvin commented Nov 26, 2024

Should I close this or should we keep the option ?

@LukeTowers
Copy link
Member

Eh, we can close it for now unless someone demonstrates a need for it.

@LukeTowers LukeTowers closed this Nov 26, 2024
@mjauvin mjauvin deleted the escape-formula branch December 4, 2024 17:12
@mjauvin mjauvin removed this from the 1.2.7 milestone Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bennothommo bennothommo Awaiting requested review from bennothommo

Assignees

@mjauvin mjauvin

Labels
enhancement PRs that implement a new feature or substantial change needs review Issues/PRs that require a review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjauvin @LukeTowers